Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run mode: continue-on-error handling for "contract not in inputs" #915

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Feb 19, 2025

Requires #918

Work towards #691

Adds a way to continue vm execution after each error instead of terminating immediately. This can be used to collect multiple execution errors at once, which is useful if you don't know in advance what storage, inputs or outputs the tx is going to need access to.

Names are still subject to bikeshedding.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@Dentosal Dentosal added enhancement New feature or request breaking A breaking api change fuel-vm Related to the `fuel-vm` crate. labels Feb 19, 2025
@Dentosal Dentosal self-assigned this Feb 19, 2025
@Dentosal Dentosal changed the title Dry run mode Dry run mode: continue-on-error foundations and nontract not in inputs handling Feb 25, 2025
@Dentosal Dentosal changed the title Dry run mode: continue-on-error foundations and nontract not in inputs handling Dry run mode: continue-on-error foundations and contract not in inputs handling Feb 25, 2025
@Dentosal Dentosal changed the title Dry run mode: continue-on-error foundations and contract not in inputs handling Dry run mode: continue-on-error handling for "contract not in inputs" Feb 25, 2025
@Dentosal Dentosal force-pushed the dento/dry-run-collect-errors branch from 9bcfbf1 to 41be4eb Compare February 26, 2025 12:40
@Dentosal Dentosal marked this pull request as ready for review February 26, 2025 16:54
@Dentosal Dentosal requested review from xgreenx and a team February 26, 2025 16:54
@Dentosal Dentosal removed the breaking A breaking api change label Feb 26, 2025
xgreenx
xgreenx previously approved these changes Feb 26, 2025
@xgreenx xgreenx requested a review from a team February 26, 2025 17:22
netrome
netrome previously approved these changes Feb 26, 2025
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo, otherwise LGTM

AurelienFT
AurelienFT previously approved these changes Feb 26, 2025
Co-authored-by: Mårten Blankfors <[email protected]>
@Dentosal Dentosal dismissed stale reviews from AurelienFT, netrome, and xgreenx via 9e66633 February 26, 2025 18:15
@Dentosal Dentosal enabled auto-merge February 26, 2025 18:35
@Dentosal Dentosal added this pull request to the merge queue Feb 26, 2025
Merged via the queue into master with commit 992651b Feb 26, 2025
39 checks passed
@Dentosal Dentosal deleted the dento/dry-run-collect-errors branch February 26, 2025 19:22
@Dentosal Dentosal mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fuel-vm Related to the `fuel-vm` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants