-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Guid? == null comparison #85
Conversation
Unit tests fail. Can you take a look at your code? |
I thought, maybe we should work on int FindBestMethod(IEnumerable methods, Expression[] args, out MethodBase method) the different created arrays seem not verry perfomant to me |
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 83.97% 84.06% +0.09%
==========================================
Files 25 25
Lines 3082 3087 +5
Branches 448 449 +1
==========================================
+ Hits 2588 2595 +7
+ Misses 365 364 -1
+ Partials 129 128 -1
Continue to review full report at Codecov.
|
fixed... |
would be nice if it could be merged, and you could create a new nuget |
can you create a new nuget? |
I did merge, and added some extra tests. However it some tests fails? Not related to guid I think, maybe I missed something... |
I fixed your test, you need to use
but there was also a error then in the lib, because the expression is not the same as the cached null expression! |
Can you create a new nuget?