Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Guid? == null comparison #85

Merged
merged 2 commits into from
May 31, 2017
Merged

Conversation

jogibear9988
Copy link
Contributor

Can you create a new nuget?

@StefH
Copy link
Collaborator

StefH commented May 31, 2017

Unit tests fail. Can you take a look at your code?

@jogibear9988
Copy link
Contributor Author

I thought, maybe we should work on

int FindBestMethod(IEnumerable methods, Expression[] args, out MethodBase method)

the different created arrays seem not verry perfomant to me

@codecov
Copy link

codecov bot commented May 31, 2017

Codecov Report

Merging #85 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   83.97%   84.06%   +0.09%     
==========================================
  Files          25       25              
  Lines        3082     3087       +5     
  Branches      448      449       +1     
==========================================
+ Hits         2588     2595       +7     
+ Misses        365      364       -1     
+ Partials      129      128       -1
Impacted Files Coverage Δ
src/System.Linq.Dynamic.Core/ExpressionParser.cs 81.14% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd9f0a...8a72624. Read the comment docs.

@jogibear9988
Copy link
Contributor Author

fixed...

@jogibear9988
Copy link
Contributor Author

would be nice if it could be merged, and you could create a new nuget

@StefH StefH merged commit 1aed80b into zzzprojects:master May 31, 2017
@StefH StefH changed the title Fix Guid? == null comparison Fix : Guid? == null comparison May 31, 2017
@StefH StefH changed the title Fix : Guid? == null comparison [Fix] : Guid? == null comparison May 31, 2017
@StefH StefH changed the title [Fix] : Guid? == null comparison [Fix] Guid? == null comparison May 31, 2017
@jogibear9988
Copy link
Contributor Author

can you create a new nuget?

@StefH
Copy link
Collaborator

StefH commented May 31, 2017

I did merge, and added some extra tests.

However it some tests fails? Not related to guid I think, maybe I missed something...
See:
https://github.com/StefH/System.Linq.Dynamic.Core/blob/master/test/System.Linq.Dynamic.Core.Tests/ExpressionTests.cs#L583

@jogibear9988
Copy link
Contributor Author

I fixed your test, you need to use

  new object[] {null}

but there was also a error then in the lib, because the expression is not the same as the cached null expression!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants