Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Sliding Cache to Constant Expression Helper #765
Introduce Sliding Cache to Constant Expression Helper #765
Changes from 7 commits
4ce4385
1d3bf0a
3d09d49
579085e
a3aede1
bda7622
72a6906
c965066
cc8482a
8d9b6bf
c8653b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private methods do not need xml-comment, expect when very special or complex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to CleanupAsync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, use
Asser.Fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, that's a Co-pilot fail! Fixed! How did I miss that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, going back to this - having trouble with xUnit - does not appear they have
Assert.Fail(..)
- I think Co-pilot suggested that as an alternative. Some StackOverflow articles show I should just throw an exception instead, which will fail it. I am not sure how I feel about that. How would you want me to trigger a failure?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand. I was using an older version from xunit in the solution.
It's added here: xunit/xunit#2609 (comment)
If you want; you upgrade all unit-test projects to use 2.5.0 which includes Assert.Fail
Else if this too much work, just keep the existing code.