Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init field only on first execution #631

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Init field only on first execution #631

merged 2 commits into from
Oct 23, 2022

Conversation

BBreiden
Copy link
Contributor

The current getter throws if called more than once, as the dictionary has already been set up.

@BBreiden
Copy link
Contributor Author

This should solve issue #629

@StefH StefH added the bug label Sep 18, 2022
@StefH StefH self-requested a review September 19, 2022 06:04
StefH
StefH requested changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@StefH StefH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BBreiden

Can you please add a unit-test DynamicClassTests.cs which tests this fix?

@BBreiden
Copy link
Contributor Author

BBreiden commented Sep 19, 2022 •
edited
Loading

I've added a test. It fails without my change and works afterwards.
@StefH Is this sufficient? Or should I add something else?

@BBreiden BBreiden requested a review from StefH October 5, 2022 09:35
@BBreiden BBreiden closed this Oct 20, 2022
@BBreiden BBreiden deleted the FixDynamicClassGetter branch October 20, 2022 06:46
@BBreiden
Copy link
Contributor Author

Suggested change wasn't approved.

@StefH
Copy link
Collaborator

StefH commented Oct 20, 2022

@BBreiden
Can you recreate your PR?

(sorry ; I did not have enough time for this project...)

@BBreiden BBreiden restored the FixDynamicClassGetter branch October 21, 2022 06:48
@BBreiden BBreiden reopened this Oct 21, 2022
@BBreiden
Copy link
Contributor Author

I reopened the PR!
:-)

@StefH StefH merged commit c1a9771 into zzzprojects:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefH StefH StefH approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BBreiden @StefH