Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for generic (static) methods, thus also support for extension… #517

Merged
merged 4 commits into from
Aug 20, 2021

Conversation

dogguts
Copy link
Contributor

@dogguts dogguts commented Jun 8, 2021

this PR provides support for generic methods (as (among others) requested in #386 ), and thus also for generic extension methods.
An actual use case for this whould be the, in EF Core 5.0, introduced "Collate" extension method, wich has a generic signatue:

// https://github.com/dotnet/efcore/blob/v5.0.7/src/EFCore.Relational/Extensions/RelationalDbFunctionsExtensions.cs 
public static TProperty Collate<TProperty>(
           [NotNull] this DbFunctions _,
           [NotNull] TProperty operand,
           [NotNull] [NotParameterized] string collation)

Also contains additional unit tests

@dogguts dogguts marked this pull request as ready for review June 8, 2021 22:15
@Nokecy
Copy link

Nokecy commented Jun 17, 2021

Is this PR reviewed? @StefH

@StefH
Copy link
Collaborator

StefH commented Jun 17, 2021

Not yet.

I'll do it.

Thanks for this PR.

@StefH StefH added the feature label Jun 20, 2021
@Nokecy
Copy link

Nokecy commented Jun 30, 2021

@dogguts Can you please resolve merge conflicts?

@dogguts
Copy link
Contributor Author

dogguts commented Jul 5, 2021

resolved 😄

@Nokecy
Copy link

Nokecy commented Aug 20, 2021

@StefH 😄

@StefH StefH merged commit cc7a0a6 into zzzprojects:master Aug 20, 2021
@dogguts dogguts deleted the genericmethods branch September 4, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants