save

[Lempireqc]

Fix for: #351

[StefH]

Hello @Lempireqc and @JonathanMagnan,

1] It may be a good idea to give a meaningful description to this pull-request (and also to #380). This helps for understanding what has been added to the project.

2] Also it can be useful to link a PR to the related issue, in that way tracking the PR and the issue is easier.

3] And maybe add/update unit-tests for this one and the previous? Or will this be done in another PR?

[JonathanMagnan]

Hello @StefH ,

You are right. I was planned to give more information on release note but it should be in the pull as well. I will update it when I will release this weekend. We maybe try sometime to save too much time ;)

This one already has a unit test for both pull: https://github.com/zzzprojects/System.Linq.Dynamic.Core/pull/381/files#diff-b752cf67daca39a6e6a249cc10ad554f

[StefH]

For 1]
Previously I did generate the release-notes automatically using GitHubReleaseNotes.exe , https://github.com/zzzprojects/System.Linq.Dynamic.Core/blob/master/GitHubReleaseNotes.txt
These release notes were based on the Tags, PullRequests and Issues.
And the PR's and Issues need to have the correct Label applied.

The file looks like : https://github.com/zzzprojects/System.Linq.Dynamic.Core/blob/master/CHANGELOG.md

For 3]
I see indeed that you have a unit-test, however, I was not expecting to find that file with that name in that location.
It's easier to keep the unit-tests grouped in the same structure, so you can see in one quick overview what tests are there.