Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more comparisons with strings #38

Merged
merged 3 commits into from
Jul 24, 2016

Conversation

jogibear9988
Copy link
Contributor

No description provided.

@jogibear9988
Copy link
Contributor Author

Sorry, I could not create unit tests, because I could not compile it on my system:

I get this error:

The .NET Core SDK is not installed or cannot be found under the path C:\Program Files\dotnet\bin. These components are required to build and run this project. Download the version of .NET Core SDK specified in global.json or update the SDK version in global.json to the version that is installed.

@jogibear9988
Copy link
Contributor Author

Maybe you could help me, so I can fix the compilation errors and create tests.

@StefH
Copy link
Collaborator

StefH commented Jul 23, 2016

You need latest vs2015 update 3.
Also need .net core rc2 sdk. And maybe also .net core tooling for vs2015.

See this linl https://www.microsoft.com/net

@jogibear9988
Copy link
Contributor Author

I needed to uninstall a old Version, then it worked.

@StefH
Copy link
Collaborator

StefH commented Jul 24, 2016

some comments

  • TypeConverter is present for silverlight, so I'll enable this
  • The dependencies for older frameworks on System.ComponentModel.TypeConverter is not needed, it's already present.

I'll fix above items and add code to new branch, you can review/test this and if you agree, I merge back to main.

StefH added a commit that referenced this pull request Jul 24, 2016
@StefH StefH merged commit 4010cf2 into zzzprojects:master Jul 24, 2016
@jogibear9988
Copy link
Contributor Author

I've seen you changed some unit tests using left and right as value. I think we should nearly modify all tests to compare both sides in ExpressionParser

@jogibear9988 jogibear9988 deleted the patch-2 branch July 24, 2016 21:59
@StefH
Copy link
Collaborator

StefH commented Jul 25, 2016

Indeed, surely for new functionality we should add left and right unit-tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants