Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize property or field over the type / Fix find for static property or field #357

Merged
merged 3 commits into from
Mar 19, 2020

Conversation

konzen
Copy link
Contributor

@konzen konzen commented Mar 16, 2020

When the type and property have the same name the parser takes the property instead of type

@konzen konzen changed the title When the type and property have the same name the parser takes the pr… When the type and property have the same name the parser takes the prWhen the type and property have the same name the parser takes the property instead of type Mar 16, 2020
@konzen konzen changed the title When the type and property have the same name the parser takes the prWhen the type and property have the same name the parser takes the property instead of type When the type and property have the same name the parser takes the property instead of type Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #357 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   88.49%   88.56%   +0.07%     
==========================================
  Files          46       46              
  Lines        4503     4531      +28     
==========================================
+ Hits         3985     4013      +28     
  Misses        518      518              
Impacted Files Coverage Δ
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 88.17% <100.00%> (+0.32%) ⬆️
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0.00%> (-1.82%) ⬇️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100.00% <0.00%> (ø)
...tem.Linq.Dynamic.Core/ParameterExpressionHelper.cs 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ae34d...5f00982. Read the comment docs.

@StefH StefH self-requested a review March 16, 2020 18:57
Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add 2 unit tests in https://github.com/StefH/System.Linq.Dynamic.Core/blob/master/test/System.Linq.Dynamic.Core.Tests/Parser/ExpressionParserTests.cs to make sure that the normal situation and the new situation work correct ?

@konzen konzen changed the title When the type and property have the same name the parser takes the property instead of type Prioritize property or field over the type / Fix find for static property or field Mar 19, 2020
@konzen
Copy link
Contributor Author

konzen commented Mar 19, 2020

Changed Title

Included tests

@StefH
Copy link
Collaborator

StefH commented Feb 4, 2023

@konzen
I needed to introduce a new config setting for this. Else existing code breaks. (--> #662)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants