Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correctly type cast of nulls (and other constants) #354

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

rockResolve
Copy link
Contributor

Add tests that check returned type
Also fixes casts e.g. "int?(5)" to return nullable int type

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #354 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files          46       46           
  Lines        4503     4504    +1     
=======================================
+ Hits         3985     3986    +1     
  Misses        518      518           
Impacted Files Coverage Δ
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0.00%> (-1.82%) ⬇️
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 88.15% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7ae34d...be5dc3a. Read the comment docs.

Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

@StefH StefH merged commit 22c3a14 into zzzprojects:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants