Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix np(...) logic when default value is supplied #342

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Jan 15, 2020

@StefH StefH added the bug label Jan 15, 2020
@StefH StefH self-assigned this Jan 15, 2020
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #342 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #342     +/-   ##
=========================================
+ Coverage   88.11%   88.21%   +0.1%     
=========================================
  Files          46       46             
  Lines        4501     4499      -2     
=========================================
+ Hits         3966     3969      +3     
+ Misses        535      530      -5
Impacted Files Coverage Δ
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 86.9% <100%> (-0.01%) ⬇️
...ystem.Linq.Dynamic.Core/Parser/ExpressionHelper.cs 96.8% <100%> (+0.09%) ⬆️
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 98.63% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1046418...6b9f9f0. Read the comment docs.

@StefH StefH merged commit ea88769 into master Jan 15, 2020
@StefH StefH deleted the fix_np_nested_nonprimitive_types branch January 15, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant