Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message in case property or field is not present in new() #340

Merged
merged 5 commits into from
Feb 29, 2020

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Jan 13, 2020

No description provided.

@StefH StefH added the feature label Jan 13, 2020
@StefH StefH self-assigned this Jan 13, 2020
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #340 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
+ Coverage    88.2%   88.49%   +0.28%     
==========================================
  Files          46       46              
  Lines        4520     4503      -17     
==========================================
- Hits         3987     3985       -2     
+ Misses        533      518      -15
Impacted Files Coverage Δ
src/System.Linq.Dynamic.Core/Validation/Check.cs 47.14% <0%> (-0.75%) ⬇️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <0%> (ø) ⬆️
...em.Linq.Dynamic.Core/DynamicQueryableExtensions.cs 96.52% <0%> (ø) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionHelper.cs 96.8% <0%> (+0.09%) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 87.84% <0%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9008d81...a362d48. Read the comment docs.

@StefH StefH changed the title Beter error message in case property or field is not present in new() Better error message in case property or field is not present in new() Jan 14, 2020
@StefH StefH merged commit 025cc31 into master Feb 29, 2020
@StefH StefH deleted the Beter_ErrorMessage_InCasePropertyIsNotPresent branch February 29, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant