Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseNumber using CultureInfo from configuration #323

Merged
merged 5 commits into from
Dec 16, 2019
Merged

ParseNumber using CultureInfo from configuration #323

merged 5 commits into from
Dec 16, 2019

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Nov 20, 2019

@StefH StefH added the feature label Nov 20, 2019
@StefH StefH self-assigned this Nov 20, 2019
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #323 into master will increase coverage by 0.11%.
The diff coverage is 91.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
+ Coverage   88.17%   88.29%   +0.11%     
==========================================
  Files          44       45       +1     
  Lines        4475     4477       +2     
==========================================
+ Hits         3946     3953       +7     
+ Misses        529      524       -5
Impacted Files Coverage Δ
src/System.Linq.Dynamic.Core/Parser/TypeHelper.cs 96% <ø> (+4.52%) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <100%> (ø) ⬆️
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs 98.8% <100%> (ø) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 86.85% <100%> (ø) ⬆️
...rc/System.Linq.Dynamic.Core/Parser/NumberParser.cs 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f8c65c...521858a. Read the comment docs.

@StefH StefH merged commit f23e996 into master Dec 16, 2019
@StefH StefH deleted the ParseNumber branch December 16, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant