-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SumAsync #290
Added SumAsync #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests fail.
Because the SumAsync has multiple overloads. See https://docs.microsoft.com/en-us/dotnet/api/system.data.entity.queryableextensions.sumasync?view=entity-framework-6.2.0
src/Microsoft.EntityFrameworkCore.DynamicLinq/EFDynamicQueryableExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please take a look at my comments
src/Microsoft.EntityFrameworkCore.DynamicLinq/EFDynamicQueryableExtensions.cs
Outdated
Show resolved
Hide resolved
Also add a new test file |
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 87.5% 87.25% -0.25%
==========================================
Files 42 42
Lines 4280 4324 +44
==========================================
+ Hits 3745 3773 +28
- Misses 535 551 +16
Continue to review full report at Codecov.
|
@wertzui Can you maybe add a SumAsync exmple to https://github.com/StefH/System.Linq.Dynamic.Core/blob/master/src-console/ConsoleAppEF1.1/Program.cs ? In that way you can be sure that this works for NETCore 1.x |
The SumAsync method was missing from the Entity Framework Core extension methods.