Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Enumerations from System Namespace (e.g. StringComparison) #275

Merged
merged 2 commits into from
Jun 6, 2019
Merged

Support Enumerations from System Namespace (e.g. StringComparison) #275

merged 2 commits into from
Jun 6, 2019

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Jun 6, 2019

No description provided.

@StefH StefH added the feature label Jun 6, 2019
@StefH StefH self-assigned this Jun 6, 2019
@codecov
Copy link

codecov bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #275 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   86.94%   87.04%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        4220     4260      +40     
==========================================
+ Hits         3669     3708      +39     
- Misses        551      552       +1
Impacted Files Coverage Δ
.../System.Linq.Dynamic.Core/Parser/KeywordsHelper.cs 100% <100%> (ø) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...nq.Dynamic.Core/Parser/EnumerationsFromMscorlib.cs 100% <100%> (ø)
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <0%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254a65e...c4ba48d. Read the comment docs.

8 similar comments
@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #275 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   86.94%   87.04%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        4220     4260      +40     
==========================================
+ Hits         3669     3708      +39     
- Misses        551      552       +1
Impacted Files Coverage Δ
.../System.Linq.Dynamic.Core/Parser/KeywordsHelper.cs 100% <100%> (ø) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...nq.Dynamic.Core/Parser/EnumerationsFromMscorlib.cs 100% <100%> (ø)
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <0%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254a65e...c4ba48d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #275 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   86.94%   87.04%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        4220     4260      +40     
==========================================
+ Hits         3669     3708      +39     
- Misses        551      552       +1
Impacted Files Coverage Δ
.../System.Linq.Dynamic.Core/Parser/KeywordsHelper.cs 100% <100%> (ø) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...nq.Dynamic.Core/Parser/EnumerationsFromMscorlib.cs 100% <100%> (ø)
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <0%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254a65e...c4ba48d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #275 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   86.94%   87.04%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        4220     4260      +40     
==========================================
+ Hits         3669     3708      +39     
- Misses        551      552       +1
Impacted Files Coverage Δ
.../System.Linq.Dynamic.Core/Parser/KeywordsHelper.cs 100% <100%> (ø) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...nq.Dynamic.Core/Parser/EnumerationsFromMscorlib.cs 100% <100%> (ø)
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <0%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254a65e...c4ba48d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #275 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   86.94%   87.04%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        4220     4260      +40     
==========================================
+ Hits         3669     3708      +39     
- Misses        551      552       +1
Impacted Files Coverage Δ
.../System.Linq.Dynamic.Core/Parser/KeywordsHelper.cs 100% <100%> (ø) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...nq.Dynamic.Core/Parser/EnumerationsFromMscorlib.cs 100% <100%> (ø)
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <0%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254a65e...c4ba48d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #275 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   86.94%   87.04%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        4220     4260      +40     
==========================================
+ Hits         3669     3708      +39     
- Misses        551      552       +1
Impacted Files Coverage Δ
.../System.Linq.Dynamic.Core/Parser/KeywordsHelper.cs 100% <100%> (ø) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...nq.Dynamic.Core/Parser/EnumerationsFromMscorlib.cs 100% <100%> (ø)
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <0%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254a65e...c4ba48d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #275 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   86.94%   87.04%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        4220     4260      +40     
==========================================
+ Hits         3669     3708      +39     
- Misses        551      552       +1
Impacted Files Coverage Δ
.../System.Linq.Dynamic.Core/Parser/KeywordsHelper.cs 100% <100%> (ø) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...nq.Dynamic.Core/Parser/EnumerationsFromMscorlib.cs 100% <100%> (ø)
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <0%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254a65e...c4ba48d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #275 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   86.94%   87.04%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        4220     4260      +40     
==========================================
+ Hits         3669     3708      +39     
- Misses        551      552       +1
Impacted Files Coverage Δ
.../System.Linq.Dynamic.Core/Parser/KeywordsHelper.cs 100% <100%> (ø) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...nq.Dynamic.Core/Parser/EnumerationsFromMscorlib.cs 100% <100%> (ø)
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <0%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254a65e...c4ba48d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #275 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   86.94%   87.04%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        4220     4260      +40     
==========================================
+ Hits         3669     3708      +39     
- Misses        551      552       +1
Impacted Files Coverage Δ
.../System.Linq.Dynamic.Core/Parser/KeywordsHelper.cs 100% <100%> (ø) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...nq.Dynamic.Core/Parser/EnumerationsFromMscorlib.cs 100% <100%> (ø)
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <0%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254a65e...c4ba48d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #275 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   86.94%   87.04%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        4220     4260      +40     
==========================================
+ Hits         3669     3708      +39     
- Misses        551      552       +1
Impacted Files Coverage Δ
.../System.Linq.Dynamic.Core/Parser/KeywordsHelper.cs 100% <100%> (ø) ⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs 100% <100%> (ø) ⬆️
...nq.Dynamic.Core/Parser/EnumerationsFromMscorlib.cs 100% <100%> (ø)
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 96.81% <0%> (-1.82%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 100% <0%> (+6.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254a65e...8798fd4. Read the comment docs.

@StefH StefH merged commit e0f0f0a into master Jun 6, 2019
@StefH StefH deleted the Support_StringComparison branch June 6, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@StefH StefH

Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StefH