-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for overloaded op_Equality #273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 96.52% 86.85% -9.67%
==========================================
Files 41 41
Lines 7244 4221 -3023
==========================================
- Hits 6992 3666 -3326
- Misses 252 555 +303
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at my comments.
var qry = testList.AsQueryable(); | ||
|
||
// Act | ||
var expectedX = (ulong) long.MaxValue + 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var expectedX = (ulong) long.MaxValue + 3; | |
ulong expectedX = (ulong) long.MaxValue + 3; |
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 96.52% 86.85% -9.67%
==========================================
Files 41 41
Lines 7244 4221 -3023
==========================================
- Hits 6992 3666 -3326
- Misses 252 555 +303
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 96.52% 86.84% -9.68%
==========================================
Files 41 41
Lines 7244 4220 -3024
==========================================
- Hits 6992 3665 -3327
- Misses 252 555 +303
Continue to review full report at Codecov.
|
Thanks a lot for this PR. I'll create a new NuGet tomorrow. |
Equality operator doesnot work for custom class and string. since both are non value type that is why it do not enters the changed code. Same will happen for 2 custom class comparision |
@mehdisalehi Please provide a example or unit-test. |
@StefH Below is the example of showing it works for integer but not for string.
|
Issue #272.
When the types mismatch, but support overloaded Equality/Inequality operators, use those.