Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating Parameterized SQL (by sspekinc) #213

Merged
merged 24 commits into from
Oct 27, 2018
Merged

Generating Parameterized SQL (by sspekinc) #213

merged 24 commits into from
Oct 27, 2018

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Oct 24, 2018

No description provided.

sspekinc and others added 21 commits July 21, 2018 18:10
Converting constant expressions to the wrapped ones will enable the generated SQL is to be parameterized as proposed in the following blog post.

https://github.com/graeme-hill/gblog/blob/master/source_content/articles/2014.139_entity-framework-dynamic-queries-and-parameterization.mkd
Update DynamicExpressionParserTests.cs
@StefH StefH changed the title Patch 1 Generating Parameterized SQL (Stef) Oct 24, 2018
@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #213 into master will decrease coverage by 0.75%.
The diff coverage is 63.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   82.69%   81.93%   -0.76%     
==========================================
  Files          37       39       +2     
  Lines        3716     3809      +93     
  Branches      509      529      +20     
==========================================
+ Hits         3073     3121      +48     
- Misses        501      535      +34     
- Partials      142      153      +11
Impacted Files Coverage Δ
...rc/System.Linq.Dynamic.Core/Parser/WrappedValue.cs 100% <100%> (ø)
...ystem.Linq.Dynamic.Core/Parser/ExpressionHelper.cs 79.57% <100%> (+1.88%) ⬆️
...q.Dynamic.Core/Parser/ConstantExpressionWrapper.cs 55.55% <55.55%> (ø)
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs 97.05% <0%> (-0.99%) ⬇️
src/System.Linq.Dynamic.Core/Parser/TypeHelper.cs 86.79% <0%> (-0.48%) ⬇️
...namic.Core/Parser/SupportedMethods/MethodFinder.cs 89.86% <0%> (-0.27%) ⬇️
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 78.42% <0%> (-0.19%) ⬇️
...tem.Linq.Dynamic.Core/Parser/ExpressionPromoter.cs 90.19% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a183117...e350167. Read the comment docs.

@StefH StefH changed the title Generating Parameterized SQL (Stef) Generating Parameterized SQL (by sspekinc) Oct 27, 2018
@StefH StefH merged commit 8fbec9b into master Oct 27, 2018
@StefH StefH deleted the patch-1 branch October 27, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants