-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ExpressionPromoter plugable #212
Merged
StefH
merged 6 commits into
zzzprojects:master
from
david-garcia-garcia:fix-expression-promoter
Oct 27, 2018
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
src/System.Linq.Dynamic.Core/Parser/IExpressionPromoter.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
using System.Linq.Expressions; | ||
|
||
namespace System.Linq.Dynamic.Core.Parser | ||
{ | ||
/// <summary> | ||
/// Expression promoter is used to promote object or value types | ||
/// to their destination type when an automatic promotion is available | ||
/// such as: int to int? | ||
/// </summary> | ||
public interface IExpressionPromoter | ||
{ | ||
/// <summary> | ||
/// Promote an expression | ||
/// </summary> | ||
/// <param name="expr">Source expression</param> | ||
/// <param name="type">Destionation data type to promote</param> | ||
/// <param name="exact">If the match must be exact</param> | ||
/// <param name="convertExpr">Convert expression</param> | ||
/// <returns></returns> | ||
Expression Promote(Expression expr, Type type, bool exact, bool convertExpr); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
using System.Linq.Dynamic.Core.CustomTypeProviders; | ||
using System.Linq.Dynamic.Core.Parser; | ||
|
||
namespace System.Linq.Dynamic.Core | ||
{ | ||
|
@@ -22,6 +23,8 @@ public class ParsingConfig | |
|
||
private IDynamicLinkCustomTypeProvider _customTypeProvider; | ||
|
||
private IExpressionPromoter _expressionPromoter; | ||
|
||
/// <summary> | ||
/// Gets or sets the <see cref="IDynamicLinkCustomTypeProvider"/>. | ||
/// </summary> | ||
|
@@ -46,6 +49,25 @@ public IDynamicLinkCustomTypeProvider CustomTypeProvider | |
} | ||
} | ||
|
||
/// <summary> | ||
/// Gets or sets the <see cref="IExpressionPromoter"/>. | ||
/// </summary> | ||
public IExpressionPromoter ExpressionPromoter | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add a unit test where you implement a different |
||
{ | ||
get | ||
{ | ||
return _expressionPromoter ?? (_expressionPromoter = new ExpressionPromoter()); | ||
} | ||
|
||
set | ||
{ | ||
if (_expressionPromoter != value) | ||
{ | ||
_expressionPromoter = value; | ||
} | ||
} | ||
} | ||
|
||
/// <summary> | ||
/// Determines if the context keywords (it, parent, and root) are valid and usable inside a Dynamic Linq string expression. | ||
/// Does not affect the usability of the equivalent context symbols ($, ^ and ~). | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.