Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Parsing Config not passed down to expression parser in JOIN #201

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Fix Parsing Config not passed down to expression parser in JOIN #201

merged 1 commit into from
Sep 4, 2018

Conversation

david-garcia-garcia
Copy link
Contributor

The ParsingConfiguration object is not properly propagated to CheckOuterAndInnerTypes() when calling the extension method Join.

@codecov
Copy link

codecov bot commented Sep 4, 2018 •
edited
Loading

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #201   +/-   ##
======================================
  Coverage    82.5%   82.5%           
======================================
  Files          37      37           
  Lines        3681    3681           
  Branches      506     506           
======================================
  Hits         3037    3037           
  Misses        502     502           
  Partials      142     142
Impacted Files Coverage Δ
...em.Linq.Dynamic.Core/DynamicQueryableExtensions.cs 95.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a075abf...56668c6. Read the comment docs.

StefH
StefH approved these changes Sep 4, 2018
View reviewed changes
Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this fix!!!
Does this cover all scenarios?

@david-garcia-garcia
Copy link
Contributor Author

I checked usages of ParseLambda() and all 27 references are properly propagating a ParsingConfig after the change.

There is an overload that has 0 references, and which does not take a ParsingConfig.

@StefH StefH merged commit 47125b8 into zzzprojects:master Sep 4, 2018
@codecov-io
Copy link

codecov-io commented Oct 16, 2018 •
edited by codecov bot
Loading

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #201   +/-   ##
======================================
  Coverage    82.5%   82.5%           
======================================
  Files          37      37           
  Lines        3681    3681           
  Branches      506     506           
======================================
  Hits         3037    3037           
  Misses        502     502           
  Partials      142     142
Impacted Files Coverage Δ
...em.Linq.Dynamic.Core/DynamicQueryableExtensions.cs 95.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a075abf...56668c6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefH StefH StefH approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-garcia-garcia @codecov-io @StefH