-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for parsing Guid and string in the same condition #200
Merged
Merged
Changes from 16 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
eca21da
Fix for ParseLambda with itType and resultType: correct order of argu…
4b7d15a
Add references for missing classes
cd4b420
Fix for missing classes: UserState and UserProfileDetails
c7d29f4
Small update on unit-test (no need to check for `DoesNotThrow`)
StefH e6ddce6
add comment to appveyor
StefH 9a5e5e3
Only run SonarScanner on master branch
StefH 02bda33
APPVEYOR_REPO_BRANCH
StefH e77c116
APPVEYOR_PULL_REQUEST_NUMBER
StefH d7d432b
No working unit test for inner double quotes
2c840f8
Fix for inner double quotes
8590347
Merge branch 'master' into pull-requests-branch
OlegNadymov e13c9d1
Using {}
6213fd1
Fix for parsing Guid and string in the same condition
4d6a4d5
Merge branch 'master' into pull-requests-branch
OlegNadymov 43765a3
FIxes after review
10bb5bd
Merge branch 'pull-requests-branch' of https://github.com/OlegNadymov…
a9c93f2
Fixes after review: just add comments and remove empty lines after br…
cc90915
Fix for parsing expression with custom types with implicit convertions
ea0f3bd
Use "string" instead of "var"
1290d20
Remove empty line
53c73ac
Fix for LessGreater (<>) parsing.
d143a0b
Fix for unit test
dc9e24d
Changes according to review
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,8 @@ namespace System.Linq.Dynamic.Core.Tests | |
{ | ||
public class DynamicExpressionParserTests | ||
{ | ||
|
||
|
||
private class MyClass | ||
{ | ||
public int Foo() | ||
|
@@ -452,5 +454,56 @@ public void ParseLambda_With_InnerStringLiteral() | |
object result = del.DynamicInvoke(String.Empty); | ||
Check.That(result).IsEqualTo(originalTrueValue); | ||
} | ||
|
||
[Fact] | ||
public void ParseLambda_With_Guid_Equals_Null() | ||
{ | ||
var user = new User(); | ||
Guid guidEmpty = Guid.Empty; | ||
Guid someId = Guid.NewGuid(); | ||
string expressionText = $"iif(@0.Id == null, @0.Id == Guid.Parse(\"{someId}\"), Id == Id)"; | ||
|
||
var lambda = DynamicExpressionParser.ParseLambda(typeof(User), null, expressionText, user); | ||
var boolLambda = lambda as Expression<Func<User, bool>>; | ||
Assert.NotNull(boolLambda); | ||
|
||
var del = lambda.Compile(); | ||
bool result = (bool) del.DynamicInvoke(user); | ||
Assert.True(result); | ||
} | ||
|
||
[Fact] | ||
public void ParseLambda_With_Null_Equals_Guid() | ||
{ | ||
var user = new User(); | ||
Guid guidEmpty = Guid.Empty; | ||
Guid someId = Guid.NewGuid(); | ||
string expressionText = $"iif(null == @0.Id, @0.Id == Guid.Parse(\"{someId}\"), Id == Id)"; | ||
|
||
var lambda = DynamicExpressionParser.ParseLambda(typeof(User), null, expressionText, user); | ||
var boolLambda = lambda as Expression<Func<User, bool>>; | ||
Assert.NotNull(boolLambda); | ||
|
||
var del = lambda.Compile(); | ||
bool result = (bool) del.DynamicInvoke(user); | ||
Assert.True(result); | ||
} | ||
|
||
[Fact] | ||
public void ParseLambda_With_Guid_Equals_String() | ||
{ | ||
Guid someId = Guid.NewGuid(); | ||
Guid anotherId = Guid.NewGuid(); | ||
var user = new User(); | ||
user.Id = someId; | ||
Guid guidEmpty = Guid.Empty; | ||
string expressionText = $"iif(@0.Id == \"{someId}\", Guid.Parse(\"{guidEmpty}\"), Guid.Parse(\"{anotherId}\"))"; | ||
|
||
var lambda = DynamicExpressionParser.ParseLambda(typeof(User), null, expressionText, user); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not also check here on: var boolLambda = lambda as Expression<Func<User, bool>>;
Assert.NotNull(boolLambda); ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. I've added it:
|
||
var del = lambda.Compile(); | ||
Guid result = (Guid) del.DynamicInvoke(user); | ||
Assert.Equal(guidEmpty, result); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change comment to: