Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ParseLambda with itType and resultType: correct order of arguments #193

Merged
merged 8 commits into from
Aug 2, 2018

Conversation

OlegNadymov
Copy link
Contributor

I've created the separate branch for my fix.

@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #193 into master will increase coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #193      +/-   ##
=========================================
+ Coverage   82.53%   82.8%   +0.27%     
=========================================
  Files          37      37              
  Lines        3658    3658              
  Branches      493     493              
=========================================
+ Hits         3019    3029      +10     
+ Misses        501     498       -3     
+ Partials      138     131       -7
Impacted Files Coverage Δ
...ystem.Linq.Dynamic.Core/DynamicExpressionParser.cs 75.92% <100%> (+5.55%) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 77.98% <0%> (+0.16%) ⬆️
src/System.Linq.Dynamic.Core/Parser/TypeHelper.cs 88.2% <0%> (+0.47%) ⬆️
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs 98.03% <0%> (+1.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1cfbe2...e77c116. Read the comment docs.

@StefH
Copy link
Collaborator

StefH commented Aug 2, 2018

OK. I made a small fix to the unit-test and fixed sonarcloud integration.

I can merge this PR to master, however do you also need a new NuGet ?

@OlegNadymov
Copy link
Contributor Author

Yes, I need a new NuGet. Could you do it?

@StefH StefH merged commit fa1b6f2 into zzzprojects:master Aug 2, 2018
@StefH
Copy link
Collaborator

StefH commented Aug 2, 2018

NuGet uploaded

@OlegNadymov
Copy link
Contributor Author

@StefH thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants