Generating Parameterized SQL

[sspekinc]

Converting constant expressions to the wrapped ones will enable the generated SQL is to be parameterized as proposed in the following blog post.

https://github.com/graeme-hill/gblog/blob/master/source_content/articles/2014.139_entity-framework-dynamic-queries-and-parameterization.mkd

[StefH]

Add some comments, please take a look.

[StefH]

This can be private

[StefH]

Add comment here how this is working. (Maybe add the link to that article, or maybe better to also add the article as file to this git.

[Jo1nes]

Hi, I have the same requirement and I very glad there is already a fix. Many thanks! Can you tell me if this will be included in the next release?

[StefH]

Hello @sspekinc and @Jo1nes,

There are some code review comments and 3 unit-tests fail.
See https://ci.appveyor.com/project/StefH/system-linq-dynamic-core/build/1.0.8.576 for more details.

[sspekinc]

Hi Stef, It seems I need to change the test itself. Shall I do it?

…

On Tue, Oct 23, 2018 at 9:02 AM Stef Heyenrath ***@***.***> wrote: Hello @sspekinc <https://github.com/sspekinc> and @Jo1nes <https://github.com/Jo1nes>, There are some code review comments and 3 unit-tests fail. See https://ci.appveyor.com/project/StefH/system-linq-dynamic-core/build/1.0.8.576 for more details. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#185 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APOVTtfx6jA9rWYolga8Y9jEtAFwRFuPks5unrD3gaJpZM4VZqFT> .

[StefH]

There should also be a check for unsigned long, int and short here.

Also char, bool, byte, sbyte, float, decimal and double.

Also DateTimeOffset, TimeSpan.

Double check the file PredefinedTypesHelper, this file has some lists of types which you can use.

[codecov]

Codecov Report

Merging #185 into master will decrease coverage by 0.4%.
The diff coverage is 63.3%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   82.49%   82.09%   -0.41%     
==========================================
  Files          37       39       +2     
  Lines        3702     3809     +107     
  Branches      508      529      +21     
==========================================
+ Hits         3054     3127      +73     
- Misses        501      535      +34     
  Partials      147      147

Impacted Files	Coverage Δ
...rc/System.Linq.Dynamic.Core/Parser/WrappedValue.cs	100% <100%> (ø)
...ystem.Linq.Dynamic.Core/Parser/ExpressionHelper.cs	79.57% <100%> (+1.88%)	⬆️
...q.Dynamic.Core/Parser/ConstantExpressionWrapper.cs	55.55% <55.55%> (ø)
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs	78.59% <0%> (+0.16%)	⬆️
src/System.Linq.Dynamic.Core/Parser/TypeHelper.cs	87.26% <0%> (+0.47%)	⬆️
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs	98.03% <0%> (+0.98%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a6bf6c...48c7b2d. Read the comment docs.

[StefH]

I've refactored some code.
When I run the ConsoleApp_net452_EF6 example, the SQL profiler shows this trace for all 3 queries:

exec sp_executesql N'SELECT TOP (1) 
    [Extent1].[Id] AS [Id], 
    [Extent1].[EmployeeNumber] AS [EmployeeNumber], 
    [Extent1].[FirstName] AS [FirstName], 
    [Extent1].[LastName] AS [LastName], 
    [Extent1].[Email] AS [Email], 
    [Extent1].[HireDate] AS [HireDate], 
    [Extent1].[CompanyId] AS [CompanyId], 
    [Extent1].[CountryId] AS [CountryId], 
    [Extent1].[FunctionId] AS [FunctionId], 
    [Extent1].[SubFunctionId] AS [SubFunctionId], 
    [Extent1].[Assigned] AS [Assigned]
    FROM [dbo].[KendoGrid_Employee] AS [Extent1]
    WHERE [Extent1].[EmployeeNumber] > @p__linq__0',N'@p__linq__0 int',@p__linq__0=1000

exec sp_executesql N'SELECT TOP (1) 
    [Extent1].[Id] AS [Id], 
    [Extent1].[EmployeeNumber] AS [EmployeeNumber], 
    [Extent1].[FirstName] AS [FirstName], 
    [Extent1].[LastName] AS [LastName], 
    [Extent1].[Email] AS [Email], 
    [Extent1].[HireDate] AS [HireDate], 
    [Extent1].[CompanyId] AS [CompanyId], 
    [Extent1].[CountryId] AS [CountryId], 
    [Extent1].[FunctionId] AS [FunctionId], 
    [Extent1].[SubFunctionId] AS [SubFunctionId], 
    [Extent1].[Assigned] AS [Assigned]
    FROM [dbo].[KendoGrid_Employee] AS [Extent1]
    WHERE [Extent1].[EmployeeNumber] > @p__linq__0',N'@p__linq__0 int',@p__linq__0=1001

exec sp_executesql N'SELECT TOP (1) 
    [Extent1].[Id] AS [Id], 
    [Extent1].[EmployeeNumber] AS [EmployeeNumber], 
    [Extent1].[FirstName] AS [FirstName], 
    [Extent1].[LastName] AS [LastName], 
    [Extent1].[Email] AS [Email], 
    [Extent1].[HireDate] AS [HireDate], 
    [Extent1].[CompanyId] AS [CompanyId], 
    [Extent1].[CountryId] AS [CountryId], 
    [Extent1].[FunctionId] AS [FunctionId], 
    [Extent1].[SubFunctionId] AS [SubFunctionId], 
    [Extent1].[Assigned] AS [Assigned]
    FROM [dbo].[KendoGrid_Employee] AS [Extent1]
    WHERE [Extent1].[EmployeeNumber] > @p__linq__0',N'@p__linq__0 int',@p__linq__0=1002

So it seems the code is not working ?

.

[sspekinc]

Seems good. What's next?

[StefH]

@sspekinc Looks good.

one thing I was thinking : do we want this to be default behaviour? Or make this configurable using settings?

[sspekinc]

I think it should be the default behavior but it would be good to be able to turn it off through ParsingConfig.

[StefH]

Added config setting.

Closing this PR ; somehow I need to use my own PR for merging...