New features

[jogibear9988]

• Configuration for Expression Parsing
• new for named Types

[codecov]

Codecov Report

Merging #117 into master will decrease coverage by 0.62%.
The diff coverage is 43.07%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   83.66%   83.03%   -0.63%     
==========================================
  Files          26       27       +1     
  Lines        3275     3331      +56     
  Branches      484      489       +5     
==========================================
+ Hits         2740     2766      +26     
- Misses        395      433      +38     
+ Partials      140      132       -8

Impacted Files	Coverage Δ
src/System.Linq.Dynamic.Core/GlobalConfig.cs	95% <ø> (+5%)	⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs	0% <0%> (ø)
...em.Linq.Dynamic.Core/DynamicQueryableExtensions.cs	98.26% <100%> (ø)	⬆️
...ystem.Linq.Dynamic.Core/DynamicExpressionParser.cs	56.52% <27.27%> (-43.48%)	⬇️
src/System.Linq.Dynamic.Core/ExpressionParser.cs	81.59% <51.28%> (-0.42%)	⬇️
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs	98.63% <0%> (+1.36%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d726e...aebdd1b. Read the comment docs.

[jogibear9988]

Is this patch mergeable?

[StefH]

Whats the difference between this and https://github.com/StefH/System.Linq.Dynamic.Core/blob/master/src/System.Linq.Dynamic.Core/GlobalConfig.cs?

[jogibear9988]

That GlobalConfig is static! If I use dynamiclinq within different assemblies, I can not have a different configuration!

[jogibear9988]

@StefH any comments to this commit?

[StefH]

I did add a small comment in GetTypeInfo.

And I still need to review more code in this patch.

[jogibear9988]

do I need to fix smth?

[StefH]

smth?

[jogibear9988]

something?

[StefH]

You can fix my comment on type.GetTypeInfo().BaseType

[jogibear9988]

I do not find it!

[StefH]

See comment

[StefH]

I think you can use type.GetTypeInfo().BaseType for all frameworks, so no need for an if-elif structure.

[StefH]

Sorry. Please check again.

[jogibear9988]

look at https://msdn.microsoft.com/de-de/library/system.reflection.ireflectabletype.gettypeinfo(v=vs.110).aspx
it's there since net 4.5

[jogibear9988]

And you still compile for net 4.0 so it is needed

[codecov-io]

Codecov Report

Merging #117 into master will decrease coverage by 0.62%.
The diff coverage is 46.87%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   83.66%   83.04%   -0.63%     
==========================================
  Files          26       27       +1     
  Lines        3275     3332      +57     
  Branches      484      490       +6     
==========================================
+ Hits         2740     2767      +27     
- Misses        395      432      +37     
+ Partials      140      133       -7

Impacted Files	Coverage Δ
src/System.Linq.Dynamic.Core/GlobalConfig.cs	95% <ø> (+5%)	⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs	0% <0%> (ø)
...em.Linq.Dynamic.Core/DynamicQueryableExtensions.cs	98.26% <100%> (ø)	⬆️
...ystem.Linq.Dynamic.Core/DynamicExpressionParser.cs	56.52% <27.27%> (-43.48%)	⬇️
src/System.Linq.Dynamic.Core/ExpressionParser.cs	81.6% <57.89%> (-0.41%)	⬇️
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs	98.63% <0%> (+1.36%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d726e...84461ef. Read the comment docs.

[jogibear9988]

could you create a new nuget?

[StefH]

I found an error :

private readonly ParsingConfig _parsingConfig;

_parsingConfig is never assigned a value

I'm fixing this now.

[StefH]

Uploaded new NuGet