Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VS Code Python settings #2860

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joelspadin
Copy link
Collaborator

Removed the deprecated python.formatting.provider setting and switched to using correct extension for formatting Python files now that different formatters have been broken out into separate extensions.

Limited Python analysis to only the directories containing Python scripts, so VS Code doesn't slow down while scanning all of Zephyr.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

The python.formatting.provider setting was deprecated in favor of
having a separate extension for each Python formatter and using
editor.defaultFormatter instead. This adds a recommendation for the
Black formatter extension and selects it for Python files.
This limits vscode's Python analysis to the scripts folders so it
doesn't slow down trying to scan all of Zephyr.
@joelspadin joelspadin requested a review from a team as a code owner March 9, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant