feat($rootScope): verifier for MD5 salted passwords #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow salted passwords hashed with MD5 to be verified. Accept salt as prefix or as suffix of the password. Don't allow to use as hasher. new feature
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
===========================================
- Coverage 100.00% 98.45% -1.55%
===========================================
Files 10 15 +5
Lines 512 583 +71
===========================================
+ Hits 512 574 +62
- Misses 0 5 +5
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
muhlemmer
reviewed
Mar 19, 2025
| ), nil | ||
| } | ||
|
|
||
| // Verify parses encoded and verfies password against the checksum. |
There was a problem hiding this comment.
Suggested change
| // Verify parses encoded and verfies password against the checksum. | |
| // Verify parses encoded and verifies password against the checksum. |
muhlemmer
reviewed
Mar 19, 2025
| } | ||
| c.setSaltPasswFunc(id) | ||
| if c.saltpasswfunc == nil { | ||
| return nil, fmt.Errorf("md5salted unknow identifier: %s", id) |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("md5salted unknow identifier: %s", id) | |
| return nil, fmt.Errorf("md5salted unknown identifier: %s", id) |
|
Github is being weird now and not attaching pending comments to my review. Give me a minute |
muhlemmer
reviewed
Mar 19, 2025
| }, | ||
| { | ||
| name: "wrong identifier", | ||
| args: args{"$md5salted-unknow$foo$foo"}, |
There was a problem hiding this comment.
Suggested change
| args: args{"$md5salted-unknow$foo$foo"}, | |
| args: args{"$md5salted-unknown$foo$foo"}, |
muhlemmer
reviewed
Mar 19, 2025
| args: args{Password}, | ||
| want: verifier.OK, | ||
| encoded: MD5SaltedEncodedP, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| }, | |
| }, | |
| { | |
| name: "hash decode error", | |
| args: args{Password}, | |
| want: verifier.Skip, | |
| encoded: "$md5salted-prefix$c2FsdA==$~~~~~~~", | |
| }, |
Comment on lines
+4
to
+8
| "github.com/zitadel/passwap/internal/testvalues" | ||
| "reflect" | ||
| "testing" | ||
|
|
||
| "github.com/zitadel/passwap/verifier" |
There was a problem hiding this comment.
Suggested change
| "github.com/zitadel/passwap/internal/testvalues" | |
| "reflect" | |
| "testing" | |
| "github.com/zitadel/passwap/verifier" | |
| "reflect" | |
| "testing" | |
| "github.com/zitadel/passwap/internal/testvalues" | |
| "github.com/zitadel/passwap/verifier" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow salted passwords hashed with MD5 to be verified. Accept salt as prefix or as suffix of the password. Don't allow to use as hasher.
new feature