Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Lightning wrapper into trainer #314

Merged
merged 11 commits into from
Feb 13, 2022
Merged

Move Lightning wrapper into trainer #314

merged 11 commits into from
Feb 13, 2022

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Feb 13, 2022

Make the YOLOv5 Module clean, move the Lightning wrapper into yolort.trainer.

@zhiqwang zhiqwang added API Library use interface bc-breaking Backwards Incompatible Changes labels Feb 13, 2022
@zhiqwang zhiqwang changed the title Move Lightning Wrapper into yolort.runner Move Lightning wrapper into trainer Feb 13, 2022
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #314 (58bfb65) into main (a165e17) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 58bfb65 differs from pull request most recent head 8ebef4c. Consider uploading reports for the commit 8ebef4c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
+ Coverage   94.94%   94.98%   +0.04%     
==========================================
  Files          10       11       +1     
  Lines         732      738       +6     
==========================================
+ Hits          695      701       +6     
  Misses         37       37              
Flag Coverage Δ
unittests 94.98% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_models_yolov5.py 100.00% <100.00%> (ø)
test/test_trainer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a165e17...8ebef4c. Read the comment docs.

@zhiqwang zhiqwang merged commit f661460 into main Feb 13, 2022
@zhiqwang zhiqwang deleted the split-yolov5 branch February 13, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Library use interface bc-breaking Backwards Incompatible Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant