Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug and document RandomZoomOut #289

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

datumbox
Copy link
Contributor

Ported from pytorch/vision#5278

We found a bug on the original implementation of RandomZoomOut from TorchVision, so I thought to patch this copy as well. The good news is that we plan soon to move these transforms in TorchVision main library (using the new Transforms API) so you won't have to maintain them in your repo. But until then, this will do.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #289 (775bd95) into main (51f9d41) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #289   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          11       11           
  Lines         718      718           
=======================================
  Hits          675      675           
  Misses         43       43           
Flag Coverage Δ
unittests 94.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51f9d41...775bd95. Read the comment docs.

Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @datumbox , LGTM

@zhiqwang zhiqwang merged commit 3d943e7 into zhiqwang:main Jan 25, 2022
@zhiqwang zhiqwang added the bug / fix Something isn't working label Jan 25, 2022
@datumbox datumbox deleted the patch-1 branch January 25, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants