[#985] Create a ZIP Draft to document Regtest mode #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacu
force-pushed
the
regtest-zip-draft
branch
from
8a33bbb to
e4b17fc
Compare
nuttycom
reviewed
Feb 27, 2025
There was a problem hiding this comment.
nit: it's difficult to read this on a wide monitor, please hard-wrap lines.
nuttycom
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Partial review; I have not yet reviewed beyond the section Behavior for ZIP-200 Network Upgrade Mechanism.
In general, specification language needs to be somewhat more precise than most of what is presented in this draft. In particular, the affected components and actors should be clearly identified in each portion of the specification, and particular care should be taken with respect to any conditionals. Focus on what has to happen more than the actor in each section.
|
Thank you very much for your comments @nuttycom. I've included your feedback and in-line suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #985