Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/v1.1.0 #3

Merged
merged 14 commits into from
Feb 13, 2023
Merged

Feat/v1.1.0 #3

merged 14 commits into from
Feb 13, 2023

Conversation

heerucan
Copy link
Contributor

@heerucan heerucan commented Feb 13, 2023 •
edited
Loading

#2

  • WALLoadingView 추가
  • Package.swift 리소스 변경 -> xcassets 삭제, .json 파일 추가
  • Lottie 라이브러리 dependency 추가
  • WALKit Test 코드 추가 - jsonFile

PR Point

  • json 리소스 번들화 후 외부 프로젝트에서 적용을 해야 하는 건지, 아니면 패키지 내에서 적용해야 하는 건지 잘 모르겠음
  • 우선은 본 프로젝트에 .json 파일 추가시켜둠
  • 본 프로젝트에서 Font 파일 삭제
  • 아.. 이슈 번호 착각해서 1번에 날렸다.. ...악

@heerucan heerucan self-assigned this Feb 13, 2023
@heerucan heerucan merged commit 06d6fd7 into develop Feb 13, 2023
@heerucan heerucan deleted the feat/v1.1.0 branch February 13, 2023 17:43
@heerucan heerucan restored the feat/v1.1.0 branch February 13, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heerucan heerucan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heerucan