Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor array, structured and JSON expressions. #929

Merged
merged 19 commits into from
Mar 7, 2025
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Feb 18, 2025

  • Add ArrayExpressionBuilder, StructuredExpressionBuilder and JsonExpressionBuilder;
  • Refactor ArrayExpression, StructuredExpression and JsonExpression;
  • Implement lazy arrays for array, structured and JSON types;
  • moved JSON type tests from db-sqlite, db-mysql, db-pgsql.

Related PRs

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️/❌
Fixed issues #869, #892

Tigrov and others added 3 commits February 18, 2025 17:14
…ExpressionBuilder`. Refactor `ArrayExpression`, `StructuredExpression` and `JsonExpression`. Implement lazy arrays.
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 94.75524% with 15 lines in your changes missing coverage. Please review.

Project coverage is 99.26%. Comparing base (318ec5c) to head (165e79c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...Expression/AbstractStructuredExpressionBuilder.php 80.00% 7 Missing ⚠️
src/Expression/AbstractArrayExpressionBuilder.php 72.22% 5 Missing ⚠️
src/Schema/Data/AbstractStructuredLazyArray.php 90.00% 2 Missing ⚠️
src/Schema/Data/AbstractLazyArray.php 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #929      +/-   ##
============================================
- Coverage     99.62%   99.26%   -0.36%     
- Complexity     1490     1539      +49     
============================================
  Files            81       98      +17     
  Lines          3689     3805     +116     
============================================
+ Hits           3675     3777     +102     
- Misses           14       28      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samdark
Copy link
Member

samdark commented Feb 23, 2025

Does it affect docs in any way?

@samdark
Copy link
Member

samdark commented Feb 23, 2025

Overall 👍

@Tigrov
Copy link
Member Author

Tigrov commented Feb 26, 2025

Does it affect docs in any way?

It adds new features. I plan to add the docs later, after supporting custom type-casting.

@Tigrov Tigrov added the status:code review The pull request needs review. label Feb 27, 2025
@Tigrov Tigrov requested a review from a team February 27, 2025 02:49
@Tigrov Tigrov merged commit 53e81d2 into master Mar 7, 2025
55 of 57 checks passed
@Tigrov Tigrov deleted the refactor-expressions branch March 7, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants