Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for goerli network #5

Closed
emil14 opened this issue Nov 10, 2022 · 2 comments
Closed

Support for goerli network #5

emil14 opened this issue Nov 10, 2022 · 2 comments

Comments

@emil14
Copy link

emil14 commented Nov 10, 2022

dydx/starkex moved to goerli network. Current starkex package doesn't support it. Is it possible to add such support?

	orderSignParam := starkex.OrderSignParam{
		NetworkId: 5, // dydx testnet
                // ...
	}

	signature, err := starkex.OrderSign(starkexCredsPrivateKey, orderSignParam)
	if err != nil {
		return err // <- here
	}

This is the source of error - https://github.com/yanue/starkex/blob/master/sign_order.go#L36

@yanue
Copy link
Owner

yanue commented Nov 10, 2022

just check this: 5c922d2
but I don't know if it works or not.

@emil14
Copy link
Author

emil14 commented Nov 11, 2022

but the problem is in COLLATERAL_ASSET_ID_BY_NETWORK_ID map, not ASSET_RESOLUTION

yanue added a commit that referenced this issue Dec 7, 2022
@yanue yanue closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants