Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to changes in web API #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adapt to changes in web API #13

wants to merge 1 commit into from

Conversation

thekid
Copy link
Member

@thekid thekid commented Jan 26, 2025

This pull request makes the library compatible with the upcoming xp-forge/web version 5.0, see xp-forge/web#121:

  • Input::uri() -> Input::resource() renaming
  • Logging API refactoring
  • Dropped support for PHP < 7.4, see Drop PHP 7 support xp-framework/rfc#343
  • WebSockets support. TODO: Check whether this can be done via a single AWS lamba function at all, otherwise yield errors

@thekid thekid mentioned this pull request Jan 26, 2025
5 tasks
@@ -8,8 +8,8 @@
"require" : {
"xp-framework/core": "^12.0 | ^11.0 | ^10.0",
"xp-forge/lambda": "^5.0",
"xp-forge/web": "^4.0 | ^3.0",
"php": ">=7.0.0"
"xp-forge/web": "dev-feature/websockets as 5.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be bumped to the release version once it's available

@thekid
Copy link
Member Author

thekid commented Jan 26, 2025

TODO: Check whether this can be done via a single AWS lamba function at all

This should be doable by exposing the lambda via a) HTTP API and b) Websockets gateways. Unfortunately, this means the wss://-URL differs from the https://-URL, and we would need to send a redirect instead of the Connection: upgrade headers. Needs some real-life testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant