Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't attempt to move files after build with base #13463

Merged
merged 4 commits into from
Mar 19, 2025
Merged

fix: don't attempt to move files after build with base #13463

merged 4 commits into from
Mar 19, 2025

Conversation

ascorbic
Copy link
Contributor

Changes

Currently the Cloudflare adapter attempts to move the _redirects and _routes.json files out of the base dir into the root when a base value is set in the config. This fails, because the files are already created in the root. This PR removes that code path.

Fixes #13162

Testing

Adds tests

Docs

Copy link

changeset-bot bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: f3f265c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 19, 2025
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ascorbic ascorbic merged commit d5ad591 into main Mar 19, 2025
15 checks passed
@ascorbic ascorbic deleted the cf-base branch March 19, 2025 13:54
@astrobot-houston astrobot-houston mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the "base" property causes build errors with Cloudflare adapter
2 participants