Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing): don't add site to static redirects #13447

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Mar 18, 2025

Changes

Closes #13371

To avoid possible breaking changes with the canonical tag, now the function that creates the HTML redirect accepts a relative location and an absolution location.

Testing

Added a new test. I also tested it manually to make sure that it keeps working as expected.

Docs

N/A

Verified

This commit was signed with the committer’s verified signature.
evxn Evgeniy Malyutin
Copy link

changeset-bot bot commented Mar 18, 2025

🦋 Changeset detected

Latest commit: 16c4c07

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 18, 2025
Copy link

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #13447 will not alter performance

Comparing fix/site-and-static-redirect (16c4c07) with main (9a7dcde)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico merged commit d80ba2b into main Mar 19, 2025
27 of 28 checks passed
@ematipico ematipico deleted the fix/site-and-static-redirect branch March 19, 2025 12:29
@astrobot-houston astrobot-houston mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirects that should be internal are becoming external when site is configured
2 participants