Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: experimental flag from compiler #13402

Merged
merged 9 commits into from
Mar 12, 2025
Merged

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Mar 12, 2025

Changes

Exposes the functionality implemented in the compiler: withastro/compiler#1055

I added a new experimental flag (name to bikeshed, of course).

Testing

Added a test

Docs

withastro/docs#11211

@ematipico ematipico added this to the v5.5.0 milestone Mar 12, 2025
@ematipico ematipico self-assigned this Mar 12, 2025
@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr semver: minor Change triggers a `minor` release labels Mar 12, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with one bikeshed

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Matt's suggestion is great

Copy link

changeset-bot bot commented Mar 12, 2025

🦋 Changeset detected

Latest commit: 850af41

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #13402 will not alter performance

Comparing chore/compiler-scripts-order (346c368) with main (636a196)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts on the changeset here for your consideration!

ematipico and others added 2 commits March 12, 2025 14:20
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs!

@ematipico ematipico merged commit 3e7b498 into main Mar 12, 2025
16 checks passed
@ematipico ematipico deleted the chore/compiler-scripts-order branch March 12, 2025 14:32
@astrobot-houston astrobot-houston mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants