-
Notifications
You must be signed in to change notification settings - Fork 80
msa.js doesn't work with Firefox Nightly 85 #257
Comments
Problem still exists in Firefox 85 and is also present in Firefox 86. Firefox 85 will be released very soon! (2021-01-26) Please fix this bug soon, I rely on it! |
Still broken on Firefox 90.0 (64-Bit)... |
It isn't clear what was intended with this line but the MSA appears to function without it.
The source of the issue is that the behavior of the "in" operator on an Array changed between firefox and chrome versions. `"at" in []` returned `false`, now it returns `true` this is because `at` is now a method of `Array`.
…/msa#257 but I think they mistook where the issue was coming from
If I may, I think the correct fix is not to comment "t.on("add change reset ",e,this),e.call(this)" but rather turn the "at" into an "on" a few characters before: |
Wow, how the hell did you divine this? 🤣 Thanks. |
- update msa.js and add improved fix (wilzbach/msa#257)
Hi, I've also been having problems that alignments have stopped displaying. Does the above fix mean that the tool will become available again soon? It's really useful! (Well done, and thanks!) (I am using it with |
I would not count on it - the developer has moved on to other things. Just host an edited version of msa.js yourself. (If you can't, and you trust me, and need a short-term solution, you can use this: |
Thanks for your great work!
Using
Firefox Nightly 85.0a1 (2020-12-09)
on http://msa.biojs.net/ I get the following error in my console:Maybe it's just the a nightly bug, but it could be worth looking into this error before Firefox 85 becomes mainline.
The text was updated successfully, but these errors were encountered: