Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel, jest, webpack bits #3755

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Update babel, jest, webpack bits #3755

merged 2 commits into from
Mar 11, 2020

Conversation

dholbach
Copy link
Contributor

This should fix the handlebars and serialize-javascript security alerts on GH at least.

It also updates the node requirement (I think through the jest update this was necessary) - somebody should check if we can actually make the jump.

	This should fix the handlebars and serialize-javascript
	security alerts on GH at least.

	It also updates the node requirement (I think through the
	jest update this was necessary) - somebody should check
	if we can actually make	the jump.
@dholbach dholbach requested review from fbarl and qiell March 10, 2020 11:23
@dholbach dholbach self-assigned this Mar 10, 2020
@dholbach
Copy link
Contributor Author

https://circleci.com/gh/weaveworks/scope/14642 says

[1/5] Validating package.json...
error [email protected]: The engine "node" is incompatible with this module. Expected version "^10.19.0".
error Found incompatible module

I guess something like 56f2fac is needed here?

@bboreham
Copy link
Collaborator

I applaud your efforts, but really have no idea what changes are required when you move two major versions of Node.

I think you should have permissions to push a new build image; let me know if not.

@dholbach
Copy link
Contributor Author

I think you should have permissions to push a new build image; let me know if not.

Looks like I don't. Can you help me out? My user is dholbach on Dockerhub too.

denied: requested access to the resource is denied

Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dholbach, LGTM! 🎉

Please don't forget to revert 795eaab after you merge.

@bboreham bboreham merged commit aee1408 into master Mar 11, 2020
@bboreham bboreham deleted the update-security branch March 11, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants