Move Counters into Latest #3748
Merged
+146
−368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
reviewed
Feb 18, 2020
fbarl
reviewed
Feb 18, 2020
fbarl
reviewed
Feb 18, 2020
fbarl
approved these changes
Feb 18, 2020
bboreham
force-pushed
the
move-counters-to-latest
branch
from
a1b1bc1 to
cf37b0d
Compare
The only place Counters are used is in rendering, for the number of nodes under a topology, so the overhead of holding a unique data structure in every Node is unwarranted. Counters are not set in the probe, so we don't need any backwards-compatibility in report decoding. Similarly they are not set until after all nodes are merged, so we don't need that logic.
bboreham
force-pushed
the
move-counters-to-latest
branch
from
cf37b0d to
c800ed1
Compare
|
It turned out this needed more work because |
It was relying on the previous behaviour of Merge() adding up counters.
bboreham
force-pushed
the
move-counters-to-latest
branch
from
c800ed1 to
ffa9071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only place
Countersare used is in rendering, for the number of nodes under a topology, so the overhead of holding a unique data structure in everyNodeis unwarranted.Counters are not set in the probe, so we don't need any backwards-compatibility in report decoding. Similarly they are not set until after all nodes are merged, so we don't need that logic.
(It was a bug if we did use it - merges are supposed to be idempotent).