Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor report reading #3687

Merged
merged 4 commits into from
Sep 24, 2019
Merged

Refactor report reading #3687

merged 4 commits into from
Sep 24, 2019

Conversation

bboreham
Copy link
Collaborator

There was a lot of duplication and confusingly-similar functions.

fbarl
fbarl approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

My only comment is that I'd prefer to keep MakeFromBinary method there instead of ReadBinary if possible, but I don't consider it a blocker so feel free to merge the PR if it's not an easy change.

@bboreham
refactor: eliminate report.ReadBinary() in favour of MakeFromBinary()
13af359 
The signature of MakeFromFile changed to return a pointer for
consistency.
@bboreham
Copy link
Collaborator Author

Given review comments, I replaced the last commit (which removed MakeFromBinary()) in favour of one removing ReadBinary().

qiell
qiell approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fbarl
Copy link
Contributor

fbarl commented Sep 23, 2019

Given review comments, I replaced the last commit (which removed MakeFromBinary()) in favour of one removing ReadBinary().

Thanks @bboreham, LGTM!

@qiell qiell merged commit ca420b0 into master Sep 24, 2019
@qiell qiell deleted the refactor-reading branch September 24, 2019 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl fbarl approved these changes

@qiell qiell qiell approved these changes

@satyamz satyamz Awaiting requested review from satyamz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bboreham @fbarl @qiell