Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get weavevm tx by tag #132

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Conversation

allnil
Copy link

@allnil allnil commented Jan 28, 2025

No description provided.

@allnil allnil changed the title feat: blueprint feat: get weavevm tx by tag Jan 29, 2025
@allnil allnil marked this pull request as ready for review January 29, 2025 13:33
{
let bq_client = (&*PRECOMPILE_WVM_BIGQUERY_CLIENT).clone();
async move {
let tag = match req.tag {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to do let tag = req.tag.ok().map_err()?

Copy link

@andreespirela andreespirela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allnil allnil merged commit e0e0b5e into dev Jan 29, 2025
6 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants