Use tag to determine if to flatten or not an embedded anonymous field #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wI2L
requested changes
Aug 18, 2022
openapi/generator_test.go
Outdated
| @@ -48,6 +48,7 @@ type ( | |||
| *u | |||
| uu *u // ignored, unexported field | |||
| q // ignored, embedded field of non-struct type | |||
| *Q `json:"data"` | |||
There was a problem hiding this comment.
Could you please add another field that is an exported field of struct type, but that has no tag? To test that its fiels are then inlined.
There was a problem hiding this comment.
Also, could you keep the tag value to Q to match the current output, where each field is named by its type in the final spec.
| @@ -70,6 +70,9 @@ | |||
| "S": { | |||
| "type": "integer", | |||
| "format": "int32" | |||
| }, | |||
| "data": { | |||
|
@wI2L thanks for the review, fixed the issues. |
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 94.34% 94.35% +0.01%
==========================================
Files 7 7
Lines 973 975 +2
==========================================
+ Hits 918 920 +2
Misses 39 39
Partials 16 16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we would take for example a kube object Pod it has
ObjectMetaas an embedded field but if we render it viajson.Marshalwe would get a nicemetadatafield in our json.However in our OpenAPI definition this field would be missing.