this.game.interact.request() doesn't return control to game, have to click canvas (pointer lock limitation) -- change ESC to `

[deathcap]

When modal elements are closed by clicking outside of them (onto the main game canvas area), pointer lock is acquired, as you would expect. Consequentially this is the most usable way to close modal elements.

However, if the modal is closed programmatically (close() from voxel-modal), such as from a keybinding, then pointer lock is not re-acquired. voxel-modal attempts to:

 // resume game interaction
 this.game.interact.request();

but according to https://npmjs.org/package/pointer-lock:

// request pointer lock: warning, may require being called from a mouse event listener
pointer.request()

[deathcap]

From http://www.chromium.org/developers/design-documents/mouse-lock :

Chrome 21 added support for Mouse Lock without the full screen prerequisite:
A request to lock the mouse when the tab is not in full screen will succeed if it is made with a user gesture (e.g. a mouse click)

but:

Also, when an application exits (i.e. not due to the user pressing ESC, etc.) and reenters mouse lock there is no user gesture required and no exit instructions are shown. This provides for an improved user experience when an application frequently shifts in and out of mouse lock, such as a game with first person controls but a cursor used for inventory management.

"not due to the user pressing ESC".. sure enough I'm using escape (vkey 27) to close, but it already is used for exiting pointerlock. Changing to another key(!) allows the application to re-acquire pointer lock. Would prefer to use ESC but backquote or X are other possibilities.

[deathcap]

Changed all "close" keys from escape to `, including: voxel-modal (voxel-chest, voxel-workbench, voxel-console), voxel-inventory-dialog