Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit nullable types; Add PHP 8.4 support #220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Lakshan-Madushanka
Copy link

@Lakshan-Madushanka Lakshan-Madushanka commented Feb 9, 2025

Implicitly marking parameter as nullable is deprecated in PHP 8.4.

I used this package in my project but when upgrading to PHP 8.4 getting deprecated notices Implicitly marking parameter $length as nullable is deprecated ...


This change is Reviewable

@Lakshan-Madushanka Lakshan-Madushanka changed the title Fix implicit nullable types Fix implicit nullable types; Add PHP 8.4 support Feb 9, 2025
Copy link

sonarqubecloud bot commented Feb 9, 2025

Copy link

@jnoorman jnoorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also use the '?' in front of the type in php8.4. For example int $xx = null; could become ?int $xx = null; rather than remove the type for the function declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants