Fix CVE-2025-22870 #2012
Open
Fix CVE-2025-22870 #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lubronzhan Could you take a look this PR when you have a time? |
lubronzhan
reviewed
Mar 18, 2025
go.mod
Outdated
| @@ -1,6 +1,8 @@ | |||
| module github.com/vmware-tanzu/sonobuoy | |||
|
|
|||
| go 1.23 | |||
| go 1.23.0 | |||
There was a problem hiding this comment.
I remember there is a golang related CVE on 1.23.0, could you update this to 1.23.1? Thanks
There was a problem hiding this comment.
Thank you for comment. I updated it to 1.23.2.
|
LGTM! Just a minor comment We could also consider adding this github workflow so we don't have to manually patch CVEs https://github.com/projectcontour/contour/blob/main/.github/workflows/trivy-scan.yaml |
sonobuoy (gobinary) Total: 1 (UNKNOWN: 0, LOW: 0, MEDIUM: 1, HIGH: 0, CRITICAL: 0) ┌──────────────────┬────────────────┬──────────┬────────┬───────────────────┬───────────────┬─────────────────────────────────────────────────────────┐ │ Library │ Vulnerability │ Severity │ Status │ Installed Version │ Fixed Version │ Title │ ├──────────────────┼────────────────┼──────────┼────────┼───────────────────┼───────────────┼─────────────────────────────────────────────────────────┤ │ golang.org/x/net │ CVE-2025-22870 │ MEDIUM │ fixed │ v0.33.0 │ 0.36.0 │ Matching of hosts against proxy patterns can improperly │ │ │ │ │ │ │ │ treat an IPv6 ... │ │ │ │ │ │ │ │ https://avd.aquasec.com/nvd/cve-2025-22870 │ └──────────────────┴────────────────┴──────────┴────────┴───────────────────┴───────────────┴─────────────────────────────────────────────────────────┘ Signed-off-by: Masashi Honma <[email protected]>
masap
force-pushed
the
fix-cve-2025-22870
branch
from
eb2bb08 to
e315b84
Compare
lubronzhan
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
trivyreports trailing CVE. This PR fixes it.Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: