This repository was archived by the owner on Jul 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like 2.1.0 introduced a few changes to the VMODL database that broke usage for several people. This update should fix the issue by adding some of the things that are missing back into the VMODL database file. Fixes #157, #159 Signed-off-by: J.R. Garcia <[email protected]>
@agrare, @srobroek, @seandilda Can you all test this PR to see if it resolves the issue you are seeing? I'd like to overhaul the process that generates this VMODL file, but I'd like to go ahead and get this resolved for you all in the meantime. Thanks! |
@jrgarcia 👍 fixes my issue thanks! |
I'll be able to check in a week or so because I'm stupidly swamped in work but it sounds like the issue is resolved, thanks :)
Sent from ProtonMail Mobile
On Mon, Apr 22, 2019 at 23:10, Adam Grare ***@***.***> wrote:
***@***.***(https://github.com/jrgarcia) 👍 fixes my issue thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#160 (comment)), or [mute the thread](https://github.com/notifications/unsubscribe-auth/ABWLXZDTZNMTIPUGLM2I24LPRYERLANCNFSM4HHRWHHQ).
-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: Pmcrypto Golang 0.0.1 (ddacebe0)
Comment: https://protonmail.com
xsFNBFnYz4EBEAC/iIQRtYkw4445LsxdUpb7JQlAUKcl6sX0/JY25VeVEZic5zGY
Q0KOtbMjHlw0ZFp+tGYwHK3a9HB2Sfd6Ow7dELRHPP07162WpLszdIMaRiVIMn4u
wKXNsf4sHJL1zMJq1m9n8lY+hQUUXHxdh5JYWNL5xIUuCilIegUwpa+kLOMEN7RO
K0PnaVvBos5M5zpxplwkQZUGjl0tDQuOgbHSL9XPSAhgvwTVj8dibvO3XTiZIUPU
fA7k7w+dQ6jMHQDrCF8JabsXZdgDVsTG6kf7KBy8cIs+jDVG6n2IXxRjBJ+OMEgm
P8GWk7xOxqrYhGd4j3v38ekY88UQ8+Zb4C0dRAVy49weW8ayajmXIJYQQXucDycJ
nsN3RspvadAltVBXuqryJfnJqHJhAk8DYHw0dnPZCwfbDPH5TlLnHBid6Cmy5Me/
kRIBInkRrkxAUaaBFebMpRRFnPmrxA1KTFQZ4gMGZfpDy4TAPv3EPgy4W7dKnNys
kQueR67qsXZy4j2eXmGM3+lJiTPYPNiZhd7iuxeoXEl5AXgmU6XKnbXtyoxCkva8
W6jpEZIeh/rZ8E1M3p7FAcu9P/QrLnkX9n8ES/EVoTfKLmq0f9TwLO2OEPzrVvLv
sM0Kew8nSum/a1Iq8aQAczgKblYAJnBkAZ9ZOhpWBAnm0tXd8FtIYrAg6QARAQAB
zSsicy5yb2Jyb2VrQHZ4c2FuLmNvbSIgPHMucm9icm9la0B2eHNhbi5jb20+wsF1
BBABCAAfBQJcMaCEBgsJBwgDAgQVCAoCAxYCAQIZAQIbAwIeAQAKCRCIXNiMK7y0
+xigEACZ3AriG+PlsOgfFZp6EeXlvJ9Ml+WBZCs3H9ZDQpa8dug+UW0TwO2jJHv5
rFsSduseh0jUglfMw9EfC5lSGYbQ8KAcWvz16lbF5k7jKVK4041dmsab6HUvBrJJ
0OvtQBx5fp3bj09hb3RC8VIRgGUB+ROsUxloK2LEWkDvKVZl9THhKNJGiU+DlVFF
V204Ex8OejeTepS+FW62o7+4sut+wvzs7XoJfJ6nPBkclzCe576qdjzkuXvVmsDN
csRORqjDBUBuLMDro2PgIBxFNW2E1im9zytxVzoVxCoqO3pgeYfiH3gh14wbnY5c
9z3+QwzEC5WAfTn9RHbh+c8vWSeZlcIBB/DAe8XCH5M5M2KXAXOymTQghQR7sTNI
n098ZerqTehHj/KOjVJPnmUVokcEHcRP0KJGgzcmLVPvnGCujCxJh6nZLpJyLYsJ
/CRuCqaA0z+Vbnkx5PtTEYjVGyv2KY5ukzuHKklhGcdbfUaqMPfe6k64o/XvHjJN
sF7MbVbAxzojVgekP53svzptVW38WwXDtpEnte5Pt3FKv1+ljBvPbM0bqBk8bR77
prn8xejXguqgOt5OGkXz8tNgvirawrG9A4XcWu6AKTeNERfR6MHSZ4ApQEuVLzsl
syi6TRVObDgfb1AnJcCHDWiVup6pM7Rep+Nl/GBL1MqesvnA1M7BTQRZ2M+BARAA
1TMLvLoZM+HPjrUIAG+JyKkK1gvA4RR0bT7icVj+WbAfW3DpYrOd9dgxI7q1p8yY
/RwI2EtpRsQtX1KJedpCpglxG5l9QlUYnQTg4xqrpgMuyIYpjrseYdNND+0yAdhW
7wZgedtGVsLMRL3n6Z97E7DGWsU9KMepGns6JH6/K6rrF2x/zkLdgbq9+xgUwDQO
sgsvYqnOtzBXEC8cRT2lCiAIuJDF323pqZHssnfJWbmz1W0ha+ISthpBZgp0xu1g
4nusnddSRBcTyRmZ3KlYmoqePFr3iEyzxVrAdtWL/kuyG0GPMzEiJsjzSFXQ97+i
G+b2b4OoFenhZV7UKQCRID93u2rrFdFVGdkN9mQYMdo3R5dzLWN2RoMOHthagLWO
W84j9yAUtVaXKfVUJM8XjB70kE2ci8NrISIo/0Niq7LTGdvacCBry3yL7I2xx5VS
aKT3cESNte/JPeUOaltHfAGwPNMk8R5IDouS/NoaXQ3As1Xpe/qNdlEOYLVpjYWs
LkHtnCr6baxKiWsa9oXvZB7h5Y5FdoC0YXQ8vfE/L2tqruxK7iupDfiCDv3bYfij
nUooCHc4b6+u3LyVriasEPhL/hyJdIBWvmMjK9/nTp2/qdfaOSjVvS2h77hNoPYr
P70c0NeBZTe9KGxzNvA+YWe6upQKBEbK2f8FURX+5OkAEQEAAcLBXwQYAQgACQUC
XDGghAIbDAAKCRCIXNiMK7y0+7AMEAC8ViJNWMQ7K/0VvbiFGl+4/TfGTClOTjFb
GO3osjCRWJEo2P7RbMiidt+BrkdvPMMoI2Mudv5arT8ewAxmp4PehxHQYF9/BEMO
gJKoC1udoamea/yNySfOt59uEbXPR0guiYEp6+0Vieqz9h48iGKvcJIttC0P4+Li
ez8akHapfy/U7xUdcGEQYCRAeyBwMYjbdHo3ktd8gcZTLj4UidpK5DJ6IzczqHxJ
5weyZYgfDYPZjw62qC0tLChpvPwlu8Y76Aq/sx91FwBZ8DCVo1zuJ2fzdh1kdWCo
nyX6IzIWOOkdruyih8hGBmMXMf85AH6wUDHY+gYgFWWe3UZ+X9e89U/IwfkBicAA
uPlIhRUqpEWMO5aHmi5VfSd5+uIvwLWGtmV7IDc2ZzpOnHaTmW8ko4WwLz9NujRZ
xtkXvoKoBKSUw3sCdGcdtv6fM70r0q63LLIA7llr+ZT2okStbQUpdBIl0UrjSX2N
5bf/pz7e2BaSG5z5suncizMcyDWSQuKWoeogi2fEYk0t5MX4TEN5beHDTUIyGDNW
cgwOnAzHtvKWQLTsb1jHh0JTOgyHbYkNkmPZYaLIuahSq5KZw/VLcTSNVCkHwSA4
Vl3QIdImSTTualjwmy6zErJhFfLcB/n7kmXlewG1mDUvbiHDc8ByCdOQB/n3rcbM
uqAqCOCLCQ==
=D7eF
-----END PGP PUBLIC KEY BLOCK-----
|
@srobroek Ok. I'll probably merge this in tomorrow and push out a new release. If this ends up not fixing your issue, just reopen it and I'll take a look. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like 2.1.0 introduced a few changes to the VMODL database that
broke usage for several people. This update should fix the issue by
adding some of the things that are missing back into the VMODL database
file.
Fixes #157, #159
Signed-off-by: J.R. Garcia [email protected]