Skip to content
This repository was archived by the owner on Jul 1, 2021. It is now read-only.

Fix wsdl_types of HostPortGroup and HostVirtualNic #151

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

agrare
Copy link
Contributor

@agrare agrare commented Feb 7, 2019

Fix the wsdl_type for HostPortGroup.vswitch [ref] and HostVirtualNic.port [ref].

These were HostVirtualSwitch and HostPortGroupPort respectively but according to the wsdl should both be xsd:string types.

On master:

>> vmodl = Marshal.load(File.read("vmodl.db")); nil
=> nil
>> vmodl["HostPortGroup"]["props"].detect { |p| p["name"] == "vswitch" }["wsdl_type"]
=> "HostVirtualSwitch"
>> vmodl["HostVirtualNic"]["props"].detect { |p| p["name"] == "port" }["wsdl_type"]
=> "HostPortGroupPort"

On this branch:

>> vmodl = Marshal.load(File.read("vmodl.db")); nil
=> nil
>> vmodl["HostPortGroup"]["props"].detect { |p| p["name"] == "vswitch" }["wsdl_type"]
=> "xsd:string"
>> vmodl["HostVirtualNic"]["props"].detect { |p| p["name"] == "port" }["wsdl_type"]
=> "xsd:string"

Similar to the issue fixed here => #138

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
Fix the wsdl_type for HostPortGroup.vswitch and HostVirtualNic.port.
These were HostVirtualSwitch and HostPortGroupPort respectively but
according to the wsdl should both be xsd:string types.
@agrare
Copy link
Contributor Author

agrare commented Feb 7, 2019

Travis should be fixed by #152

@agrare agrare closed this Feb 7, 2019
@agrare agrare reopened this Feb 7, 2019
@jrgarcia jrgarcia merged commit 8469e8b into vmware-archive:master Feb 7, 2019
@jrgarcia
Copy link
Contributor

jrgarcia commented Feb 7, 2019

I'll see about releasing a new version with this fix in it tonight or tomorrow. Thanks again for your help!

@agrare agrare deleted the fix_host_network_port branch February 7, 2019 23:30
@agrare
Copy link
Contributor Author

agrare commented Feb 7, 2019

Awesome thanks @jrgarcia !!

jrgarcia pushed a commit that referenced this pull request Feb 8, 2019
Bumping version to 2.0.1 for release with PR #151

Signed-off-by: J.R. Garcia <[email protected]>
@jrgarcia
Copy link
Contributor

jrgarcia commented Feb 8, 2019

v2.0.1 should be available on RubyGems with this fix now.

@agrare
Copy link
Contributor Author

agrare commented Feb 8, 2019

Thanks so much @jrgarcia

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants