Translated SPARQL interface to DE #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
previously approved these changes
Jun 20, 2024
chenejac
requested review from
matthiasluehr
and removed request for
matthiasluehr
home/src/main/resources/rdf/i18n/de_DE/interface-i18n/firsttime/vitro_UiLabel.ttl
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/de_DE/interface-i18n/firsttime/vitro_UiLabel.ttl
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/de_DE/interface-i18n/firsttime/vitro_UiLabel.ttl
Outdated
Show resolved
Hide resolved
chenejac
reviewed
Jun 20, 2024
There was a problem hiding this comment.
@hauschke I have created code suggestions from @matthiasluehr comments. In the case you decide to adopt some of Matthias comments, you can just click on Commit changes.
home/src/main/resources/rdf/i18n/de_DE/interface-i18n/firsttime/vitro_UiLabel.ttl
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/de_DE/interface-i18n/firsttime/vitro_UiLabel.ttl
Outdated
Show resolved
Hide resolved
home/src/main/resources/rdf/i18n/de_DE/interface-i18n/firsttime/vitro_UiLabel.ttl
Outdated
Show resolved
Hide resolved
…e/vitro_UiLabel.ttl Co-authored-by: Dragan Ivanovic <[email protected]>
…e/vitro_UiLabel.ttl Co-authored-by: Dragan Ivanovic <[email protected]>
…e/vitro_UiLabel.ttl Co-authored-by: Dragan Ivanovic <[email protected]>
chenejac
approved these changes
Jun 20, 2024
matthiasluehr
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue: vivo-project/VIVO#3990
What does this pull request do?
Adds labels for German translation of /admin/sparqlquery.
What's new?
Untranslated labels are now translated, some missing hyphens were added, too.
How should this be tested?
A German native speaker should have a look.
Interested parties
@VIVO-project/vivo-committers, German speaking VIVO users
Reviewers' expertise
Reviewers' report template
Please update the following template which should be used by reviewers.
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed