Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't create add url if neither of 'select from existing' nor 'provid… #385

Merged
merged 1 commit into from
Apr 27, 2023
Merged

don't create add url if neither of 'select from existing' nor 'provid… #385

merged 1 commit into from
Apr 27, 2023
+9 −1

Conversation

litvinovg
Copy link
Member

VIVO GitHub issue

What does this pull request do?

Prevents creation of button to add new object property if neither of 'select from existing' nor 'provide selection' options are set in object property configuration

How should this be tested?

  • Remove options to select from existing and provide selection from object property
  • Verify that add new object property button is not shown
  • Try the same for faux object property

Interested parties

@chenejac

@litvinovg litvinovg requested a review from chenejac April 24, 2023 13:13
@chenejac chenejac linked an issue Apr 27, 2023 that may be closed by this pull request
Add new object property button shouldn't be available if neither of 'select from existing' nor 'provide selection' options set vivo-project/VIVO#3858
Open
chenejac
chenejac approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg well done

@chenejac chenejac merged commit 6c9e215 into vivo-project:main Apr 27, 2023
chenejac added a commit that referenced this pull request May 18, 2023
@chenejac
Revert "don't create add url if neither of 'select from existing' nor…
99b1a7f 
… 'provide selection' options set (#385)"

This reverts commit 6c9e215.
@chenejac chenejac mentioned this pull request May 18, 2023
Merged
chenejac added a commit that referenced this pull request May 23, 2023
@chenejac
Revert "don't create add url if neither of 'select from existing' nor…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f19d0a0 
… 'provide selection' options set (#385)" (#389)

This reverts commit 6c9e215.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenejac chenejac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@litvinovg @chenejac