-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n-3762] Moving UI labels translations into vitro #350
[i18n-3762] Moving UI labels translations into vitro #350
Conversation
How to validate data in this PR and companion PR:webapp/src/main/webapp/WEB-INF/resources/startup_listeners.txt should be fixed
|
455d3de
to
71426f0
Compare
71426f0
to
7340b7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From vivo review, I suggest rename UiLabelsVocabulary.nt into UiLabelsVocabulary.ttl
to avoid
2022-11-29 15:07:49,027 ERROR [UpdateKnowledgeBase] Unable to load RDF from UiLabelsVocabulary.nt
org.apache.jena.riot.RiotException: [line: 1, col: 7 ] Element or attribute do not match QName production: QName::=(NCName':')?NCName.
at org.apache.jena.riot.system.ErrorHandlerFactory$ErrorHandlerStd.fatal(ErrorHandlerFactory.java:153)
Log in the report below related to this bad translation 2022-11-29 15:06:33,308 DEBUG [TranslationConverter] Add to modelurn:uuid:cdc906b0-1905-4195-8597-6bcf570258fe http://www.w3.org/1999/02/22-rdf-syntax-ns#type http://www.w3.org/2002/07/owl#NamedIndividual . |
VIVO GitHub issue: 3762
Companion PR
What does this pull request do?
Moving UI labels translations from Vitro-languages into Vitro (+ adoption of a pom file)
What's new?
webapp directories from Vitro-languages repository are not needed any more. Together with PR for doing the same for home directories from Vitro-languages should enable archiving the Vitro-languages repositories.
How should this be tested?
Interested parties
Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers