[ i18n sprint ] Decouple email templates and translations #334
Conversation
| return true; | ||
| } catch (MessagingException e) { | ||
| log.error("Failed to send message.", e); | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| private void sendMessage(MimeMessage msg) { | ||
| Thread thread = new Thread() { |
There was a problem hiding this comment.
Why the asynchronous send? I think we already have a problem where the GUI claims that emails were sent successfully even if errors occurred. It seems that this might make that harder to address.
There was a problem hiding this comment.
Before that if smtp server have some delays 20-120 sec (it is one of greylisting approaches) then web interface will freeze for that period.
I agree, current notification about successfully sent email is misleading. I guess It should be replaced with something like "The message is going to be sent shortly" and an option to look up the results in notifications journal.
There was a problem hiding this comment.
Sounds reasonable. I guess I had never encountered delays that long, but that would certainly be something to avoid. We should have a better way of verifying that emails were sent, but that seems out of scope for this PR.
|
Not merging yet pending approval of companion PR. |
* Decouple email templates and translations * provide siteName variable to error templates
Companion Vitro-languages PR
Modified FreemarkerEmailMessage and classes that used it:
Removed EmailDirective and error-email.ftl
Send email in separate thread to prevent web interface delays.
With this PR translations, extracted from email templates into property files could be used.
#How to test#
For each of installed languages execute following actions:
Interested parties
@VIVO-project/vivo-committers