Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert deployment changes #217

Merged
merged 1 commit into from
Mar 22, 2021
Merged

revert deployment changes #217

merged 1 commit into from
Mar 22, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 9, 2021

Revert to previous deployment strategy.

Relates to vivo-project/VIVO#228

@ghost ghost marked this pull request as ready for review March 10, 2021 16:08
@nicalico
Copy link
Contributor

With those branches checked out:

  • VIVO: upstream/revert-deployment-strategy
  • Vitro : upstream/revert-deployment-strategy
  • VIVO-languages : upstream/main
  • Vitro-languages : upstream/main

Built with the following command:

mvn -T 1.5C -s settings.xml -DskipTests=true -U clean install

In the following contexts:

  • On a CentOS 7 VM, in vanilla mode
  • On a CentOS 7 VM, with UQAM overlays
  • In Eclipse IDE, with UQAM overlays

Conclusion: appears to work fine in all those cases.

@litvinovg
Copy link
Member

Tested on CentOS 7 with Tomcat 8.5.55. Works fine.
Used those branches:
VIVO: revert-deployment-strategy
Vitro : revert-deployment-strategy
VIVO-languages : main
Vitro-languages : main

Copy link
Member

@litvinovg litvinovg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@brianjlowe brianjlowe merged commit e4e0a7d into main Mar 22, 2021
roflinn added a commit that referenced this pull request Mar 24, 2021
roflinn added a commit that referenced this pull request Mar 24, 2021
@ghost ghost deleted the revert-deployment-strategy branch July 8, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants